Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orchestration / fast-usdc: remove brandKey from assetInfo in privateArgs #10580

Open
0xpatrickdev opened this issue Nov 27, 2024 · 0 comments
Open
Labels
enhancement New feature or request technical-debt

Comments

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Nov 27, 2024

What is the Problem Being Solved?

Orchestration contracts that use ChainHub seed it using chainInfo and assetInfo from privateArgs. This is more recent development from using vstorage, and was introduced in #10329 and #10571.

In order to wrangle brands, it uses brandKey to provide a DenomDetail.brand using the issuerKeywordRecord. This is a bit hacky when we have other tools at our disposal, namely:

#10329 (comment)

Description of the Design

  • brandKey no longer appears in privateArgs for fast-usdc, send-anywhere, basic-flows, or auto-stake-it contracts
  • registerChainsAndAssets:
    • receives assetInfo that already contains DenomDetail.brand
    • no longer needs a brands argument

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@0xpatrickdev 0xpatrickdev added enhancement New feature or request technical-debt labels Nov 27, 2024
@0xpatrickdev 0xpatrickdev changed the title orchestration / fast-usdc: remove brandKey from assetInfo privateArgs orchestration / fast-usdc: remove brandKey from assetInfo in privateArgs Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical-debt
Projects
None yet
Development

No branches or pull requests

1 participant