[ECP-9206] Fix return type in checking adyen orders #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
RokPopov
previously approved these changes
Jul 11, 2024
|
candemiralp
approved these changes
Jul 15, 2024
raoulritter
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a fix on a earlier PR - #504 .
The isAdyenOrder() returns a promise with a boolean value here, the
statusis a boolean returned by the endpoint. However, since the isAdyenOrder() or beforeMount() wasn't async, javascript wasn't waiting for response.status in the promise but only checking the existence of the promise that was returned. By awaiting the response we receive the boolean value from the response of the request.Tested Scenarios
Refund, notification, partial-payments