Release 4.0.0 #515
Merged
Release 4.0.0 #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ECP-9226] Update syntax for default value in alter table in migration
…n panel (#504) * [ECP-9206] Remove giftcard filters while assigning pspreference and additional data * [ECP-9206] Put back giftcard filters paymentResponseHandler, update adyenOrder check function, create an endpoint for checking the pluginId type * [ECP-9206] Use orderId instead of pluginId for isAdyenOrder check * [ECP-9206] Remove redundant check on transaction for the orderId * [ECP-9206] Fix line-break and code sniffer issues * [ECP-9206] Fix passing multiple parameters in one line * [ECP-9206] Remove plugin-id comparison and check transaction only * [ECP-9206] Update outdated function definition * [ECP-9206] Update catch exception message * [ECP-9206] Make quotes consistent * [ECP-9206] Remove context parameter --------- Co-authored-by: sushmita <[email protected]>
Co-authored-by: Can Demiralp <[email protected]>
SushmitaThakur
previously approved these changes
Jul 10, 2024
peterojo
reviewed
Jul 10, 2024
| }, | ||
|
|
||
| beforeMount() { | ||
| this.isAdyenOrder(); | ||
| this.showWidget = this.adyenService.isAdyenOrder(this.order); |
There was a problem hiding this comment.
this isAdyenOrder method does not return a boolean as far as I see, can we ensure the type?
There was a problem hiding this comment.
Added the fix in this PR.
|
Would it be possible to include #514 in this release? |
peterojo
previously approved these changes
Jul 12, 2024
RokPopov
previously approved these changes
Jul 12, 2024
* [ECP-9206] Fix return type in checking adyen orders * [ECP-9206] Return false from catch block in case of error --------- Co-authored-by: sushmita <[email protected]>
|
RokPopov
approved these changes
Jul 17, 2024
raoulritter
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#505
#504
#513
#518