Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For checkout/activate, when given a commitID, fetch the branch it belongs to. #2912

Merged
merged 1 commit into from
Nov 30, 2023
Merged

For checkout/activate, when given a commitID, fetch the branch it belongs to. #2912

merged 1 commit into from
Nov 30, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Nov 30, 2023 •
edited by github-actions bot
Loading

BugDX-2328 PULL is failed if during `activate` we checked out using commitID from different branch of the project

@mitchell-as
Copy link
Contributor Author

Test failures are not due to this PR and are the usual timeouts.

@mitchell-as mitchell-as requested a review from MDrakos November 30, 2023 16:46
@mitchell-as mitchell-as marked this pull request as ready for review November 30, 2023 16:46
MDrakos
MDrakos approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mitchell-as mitchell-as reopened this Nov 30, 2023
@mitchell-as mitchell-as merged commit af176b3 into version/0-43-0-RC1 Nov 30, 2023
15 of 20 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2328 branch November 30, 2023 20:16
as-builds added a commit that referenced this pull request Nov 30, 2023
@as-builds
Merge branch version/0-43-0-RC1 to adopt changes from PR #2912
e514fe3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos