Skip to content

Commit

Permalink
Merge pull request #2912 from ActiveState/mitchell/dx-2328
Browse files Browse the repository at this point in the history
For checkout/activate, when given a commitID, fetch the branch it belongs to.
  • Loading branch information
mitchell-as authored Nov 30, 2023
2 parents 369f864 + f844a9b commit af176b3
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions internal/runbits/checkout/checkout.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,19 @@ func (r *Checkout) Run(ns *project.Namespaced, branchName, cachePath, targetPath
return "", locale.WrapError(err, "err_fetch_branch", "", branchName)
}
commitID = branch.CommitID
} else {
// It's possible the given commitID does not belong to the default project branch.
// If so, find the correct branch.
for _, branch := range pj.Branches {
belongs, err := model.CommitBelongsToBranch(ns.Owner, ns.Project, branch.Label, *commitID)
if err != nil {
return "", errs.Wrap(err, "Could not determine if the given commitID belongs to a project branch")
}
if belongs {
branchName = branch.Label
break
}
}
}

if commitID == nil {
Expand Down

0 comments on commit af176b3

Please sign in to comment.