Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate c++ demangling. #1800

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

furby-tm
Copy link
Contributor

@furby-tm furby-tm commented Oct 1, 2024

Summarize your change.

Remove the C++ demangling.

  • Removes the include for <cxxabi.h>
  • Removes any demangling logic that utilized that header.

Reference associated tests.

All tests pass.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (c0e97b0) to head (77aacef).
Report is 24 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   84.11%   81.62%   -2.50%     
==========================================
  Files         198      176      -22     
  Lines       22241    12345    -9896     
  Branches     4687     3033    -1654     
==========================================
- Hits        18709    10077    -8632     
+ Misses       2610     1728     -882     
+ Partials      922      540     -382     
Flag Coverage Δ
py-unittests 81.62% <ø> (-2.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentimelineio/stringUtils.cpp 36.36% <ø> (-8.09%) ⬇️

... and 69 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f3791...77aacef. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this removal is welcome.

@meshula meshula merged commit 987d00a into AcademySoftwareFoundation:main Oct 2, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants