Offer alternative for cxxabi on Windows (Swift+Clang). #1787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
This fixes the clang compilation of OpenTimelineIO on Microsoft Windows, when compiling with Swift. Previously, the
cxxabi.h
header was erroneously getting included in the Windows clang compilation of OpenTimelineIO'sstringUtils.cpp
file because it was being conditionally compiled for clang across all platforms, and this header does not exist on the Windows platform.cxxabi.h
is now guarded via__has_include(<cxxabi.h>)
.OTIO_HAVE_DEMANGLER
is set to1
ifcxxabi.h
exists, and0
if this header does not exist.defined(__GNUC__) || defined(__clang__)
are replaced with conditional compilation checks against the newOTIO_HAVE_DEMANGLER
preprocessor define.