Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command specific design considerations #249

Merged

Conversation

choiwab
Copy link

@choiwab choiwab commented Nov 6, 2024

Fixes #248

@choiwab choiwab added this to the v1.5 milestone Nov 6, 2024
@choiwab choiwab self-assigned this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link

@rxchell rxchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor change!


**Aspect: What Input Should Be Valid for Fields Sickness and Medicine**

- **Alternative 1 (Current choice):** Require input with at least one alphanumeric character.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be at least one alphabetic character? It's currently implemented this way

@rxchell rxchell merged commit c3404bb into AY2425S1-CS2103T-W10-2:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Design Consideration for DG
2 participants