DeveloperGuide.md: update find, clear, list person #187
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
| 2. **Entity Type Verification** | ||
| `ListCommandParser#parse` trims the input to verify the entity type, checking for `PERSON_ENTITY_STRING` or `APPOINTMENT_ENTITY_STRING`. | ||
| If the entity type is `PERSON_ENTITY_STRING`, `ListCommandParser` returns an instance of `ListPersonCommand`. |
There was a problem hiding this comment.
This is clear, but should we include it at the start of the section, since it applies to all the commmandparsers?
| 1. **Input Parsing** | ||
| The user command input is parsed in `LogicManager` by calling `AddressBookParser#parseCommand`. For a command starting with "find person", the parser creates a `FindPersonCommandParser` instance to parse specific parameters. |
There was a problem hiding this comment.
Should we remove this input parsing part for each feature, since it would be covered under the general implementation of the command at the start of the section? (you can refer to #186 for the general implementation of the entity commands, currently being worked on)
There was a problem hiding this comment.
In general, I see that I may have to modify and remove redundant steps in implementation and design consideration. I will make appropriate changes as soon as we reach a consensus on the overall structure of our Feature part of DG.
| ### 1. Predicate Composition | ||
| - **Reason**: Using predicates enables flexible filtering and reduces redundancy by allowing shared filtering logic across commands. | ||
|
|
||
| ### 2. Case-Insensitive Matching | ||
| - **Reason**: User experience is enhanced by making searches case-insensitive. | ||
|
|
| ### 1. Abstracting Clear Logic | ||
| - **Reason**: The `ClearCommand` abstract class handles shared logic for clearing different entities (person or appointment). |
There was a problem hiding this comment.
Should we move this to the start of the section, since the abstraction applies for all the commands?
There was a problem hiding this comment.
Yes, this abstract logic is common throughout all commands, we should consider making a general design consideration section.
|
Fixed by #249 |
Fixes #172