Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add second template parameter to other AoS for swap #3450

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Add second template parameter to other AoS for swap #3450

merged 2 commits into from
Jul 26, 2023

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jul 26, 2023 •
edited by WeiqunZhang
Loading

This is also needed for:

https://github.com/ECP-WarpX/WarpX/actions/runs/5649976693/job/15305447602?pr=3474
https://github.com/ECP-WarpX/WarpX/actions/runs/5649976693/job/15305447804?pr=3474

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers mentioned this pull request Jul 26, 2023
Merged
5 tasks
@WeiqunZhang
Copy link
Member

When ArrayOfStructs is used inside the class template, it's equivalent to ArrayOfStructs<ParticleType,Allocator>. Both forms are fine. But ArrayOfStructs<ParticleType> is equivalent to ArrayOfStructs<ParticleType,DefaultAllocator>, and that's not OK. That's the reason behind this PR.

@WeiqunZhang WeiqunZhang enabled auto-merge (squash) July 26, 2023 04:14
WeiqunZhang added a commit that referenced this pull request Jul 26, 2023
@atmyers @WeiqunZhang
Refactor call_f in ParticleTransformation and WriteBinaryParticleData…
8aa7dc6 
… to use constexpr if (#3448)

This results in much easier-to-interpret error messages, useful in
finding #3449 and #3450

Co-authored-by: Weiqun Zhang <[email protected]>
@WeiqunZhang WeiqunZhang merged commit b75dd9d into AMReX-Codes:development Jul 26, 2023
66 checks passed
This was referenced Jul 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang