Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flame_wave: error out if atm_delta is too small #2782

Merged
merged 2 commits into from
Mar 18, 2024
Merged

flame_wave: error out if atm_delta is too small #2782

merged 2 commits into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. flame_wave: error out if atm_delta is too small 

    If atm_delta is significantly smaller than the finest-level resolution,
the peak temperature gets reset to T_star instead of T_hi, and the hot
and cool zones end up with the same temperature profiles. I'm not
entirely sure how it happens, and it's probably fixable, but we
shouldn't be doing any actual runs with such a low resolution anyways.
I only ran into this when I was using a single level for local testing.
    @yut23
    yut23 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1535246 View commit details
    Browse the repository at this point in the history

  2. Increase atm_delta in the test inputs

    @yut23
    yut23 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bfa140f View commit details
    Browse the repository at this point in the history