flame_wave: error out if atm_delta is too small #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If atm_delta is significantly smaller than the finest-level resolution, the peak temperature gets reset to T_star instead of T_hi, and the hot and cool zones end up with the same temperature profiles. I'm not entirely sure how it happens, and it's probably fixable, but we shouldn't be doing any actual runs with such a low resolution anyways. I only ran into this when I was using a single level for local testing.
zingale
approved these changes
Mar 18, 2024
zingale
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
If atm_delta is significantly smaller than the finest-level resolution, the peak temperature gets reset to T_star instead of T_hi, and the hot and cool zones end up with the same temperature profiles.
PR motivation
I'm not entirely sure how it happens, and it's probably fixable, but we shouldn't be doing any actual runs with such a low resolution anyways. I only ran into this when I was using a single level for local testing.
PR checklist