Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent FC with old LND nodes if HTLCs are in flight while closing #2907

Merged
merged 4 commits into from
Sep 16, 2024
+7 −0
Merged

prevent FC with old LND nodes if HTLCs are in flight while closing #2907

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84dcdbb
prevent FC with old LND nodes
DerEwige Sep 13, 2024
4848954
separating "internal error case" and "link failed to shutdown" case
DerEwige Sep 13, 2024
d05a314
removed extra space
DerEwige Sep 16, 2024
982a0eb
spelling
DerEwige Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,13 @@ trait ErrorHandlers extends CommonHandlers {
// it's up to them to broadcast their commitment if they wish.
log.warning("ignoring remote 'internal error', probably coming from lnd")
stay() sending Warning(d.channelId, "ignoring your 'internal error' to avoid an unnecessary force-close")
} else if (e.toAscii == "link failed to shutdown") {
// When trying to close a channel with LND older than version 0.18.0,
// LND will send an 'link failed to shutdown' error if there are HTLCs on the channel.
// Ignoring this error will prevent a force-close.
// The channel closing is retried on every reconnect of the channel, until it succeeds.
log.warning("ignoring remote 'link failed to shutdown', probably coming from lnd")
stay() sending Warning(d.channelId, "ignoring your 'link failed to shutdown' to avoid an unnecessary force-close")
} else {
spendLocalCurrent(hasCommitments)
}
Expand Down
Loading