Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent FC with old LND nodes if HTLCs are in flight while closing #2907

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

DerEwige
Copy link
Contributor

This simple change will prevent an FC when a close is done while HTLCs are in flight with LND nodes older than 0.18.0

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very sad to implement those hacky workarounds, but if it avoids force-closed channels, it's worth it! And hopefully we can get rid of those at some point 🤞

inlined error messages
some spelling errors fixed
@DerEwige
Copy link
Contributor Author

check timed out on the 3rd to last check...
How do I rerun the check without commiting again?

@t-bast
Copy link
Member

t-bast commented Sep 16, 2024

check timed out on the 3rd to last check...
How do I rerun the check without commiting again?

Unfortunately this happens sometimes when the CI machine doesn't have enough memory available and a bitcoind instance fails to start (since our tests spin up a bunch of bitcoind instances in parallel). When that happens, I'll restart the failed build manually from github, don't worry about it.

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@t-bast t-bast merged commit a710922 into ACINQ:master Sep 16, 2024
1 check passed
@DerEwige DerEwige deleted the old_lnd_close_fc_prevention branch September 16, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants