-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GGFE-228] 에러페이지 이모지 수정 + 스토리북 추가 #974
The head ref may contain hidden characters: "GGFE-228-\uC5D0\uB7EC\uD398\uC774\uC9C0-\uC774\uBAA8\uC9C0-\uBCC0\uACBD"
Changes from 3 commits
2364b24
d63036b
da04524
e66e418
c29a60a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아니면 이거도 괜찮구요!! |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 개인적으로는 입이 없고 눈 색깔이 눈썹 색이랑 같으면 좋을 것 같아요! 다른 분들 의견도 들어봐야할 것 같습니당 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 저는 기존 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 말씀해주신 내용 반영해서 2가지 버전 추가해놨습니다! 말씀하신 내용대로 최대한 해봤는데 원하시는데로 된건지 모르겠네요 🫠 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import { useEffect } from 'react'; | ||
import { useSetRecoilState } from 'recoil'; | ||
import type { Meta, StoryObj } from '@storybook/react'; | ||
import { errorState } from 'utils/recoil/error'; | ||
import ErrorPage from 'components/error/Error'; | ||
|
||
const meta: Meta = { | ||
title: '/ErrorPage', | ||
component: ErrorPage, | ||
}; | ||
|
||
export default meta; | ||
type Story = StoryObj<typeof ErrorPage>; | ||
|
||
function useSetError() { | ||
const setError = useSetRecoilState(errorState); | ||
|
||
useEffect(() => { | ||
setError('HJ00'); | ||
}, []); | ||
} | ||
|
||
const ErrorDefault = () => { | ||
useSetError(); | ||
return <ErrorPage />; | ||
}; | ||
|
||
export const Default: Story = { | ||
render: () => <ErrorDefault />, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이게 제일 좋은 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 이게 좋은 것 같아요!