Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GGFE-228] 에러페이지 이모지 수정 + 스토리북 추가 #974

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Sep 4, 2023

📌 개요

  • 에러페이지 이모지 변경 + 스토리북 추가

💻 작업사항

  • 스토리북에서 확인하실 수 있습니다.
  • 색상이나 크기, 이모지 자체에 대해서 피드백 부탁드립니다.🙇🏻‍♂️

✅ 변경로직

@PHJoon PHJoon self-assigned this Sep 4, 2023
@PHJoon PHJoon changed the title [GGFE-228] 에러페이지 이모지 변경 + 스토리북 추가 [GGFE-228] 에러페이지 이모지 수정 + 스토리북 추가 Sep 4, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적으로는 입이 없고 눈 색깔이 눈썹 색이랑 같으면 좋을 것 같아요! 다른 분들 의견도 들어봐야할 것 같습니당

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 기존 noti_empty.svg 와 비슷하게 X자 모양의 눈만 남기는것도 좋을 것 같아요! (눈 색도 noti_empty.svg와 동일하게)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

말씀해주신 내용 반영해서 2가지 버전 추가해놨습니다! 말씀하신 내용대로 최대한 해봤는데 원하시는데로 된건지 모르겠네요 🫠

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 제일 좋은 것 같아요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이게 좋은 것 같아요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이게 좋은 것 같아요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니면 이거도 괜찮구요!!

Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

결정된 이모지 확인했습니다! 수고하셨어요~! 😆👍

Copy link
Member

@hyobb109 hyobb109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이모지 귀엽네요! 수고하셨습니다👍

@yoouyeon yoouyeon merged commit 1e1355a into main Sep 5, 2023
1 check passed
@hyobb109 hyobb109 deleted the GGFE-228-에러페이지-이모지-변경 branch October 30, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants