Adding --must-exist command line option #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtyr
force-pushed
the
jtyr-must-exist
branch
from
52c54b8 to
ef0ea2d
Compare
jtyr
force-pushed
the
jtyr-must-exist
branch
from
ef0ea2d to
63f9d1a
Compare
|
I think this should be the default behavior, but someone is probably depending on it. This solution seems fine, and I'd like to make it the default in the next major release. Please add tests, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding
--must-existcommand line option that allows to exit the execution with an error if thePATHdoesn't exist. Without this option, the execution seems to be successful which might be a problem if we want to validate schema of a particular file/directory and the file/directory doesn't exist.