Support relative schema path #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This may cause a breaking change to some use cases....I'll research a bit. |
|
As you look into this, please could you also look into the other PR #171 I have create a while ago? |
|
This was fixed in another PR. Thanks for the contribution, sorry it took so long :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a check if the specified schema is actually a path to an existing file. Without this change, the schema cannot be find if the data path and the schema path combination doesn't produce an existing path to the schema. To demonstrate this, let's have this directory structure:
If we are in the
/dir2and we run Yamale, the schema is not found:cd /dir2 yamale -s ./schemas/myfile.yaml /dir1/data/myfile.yaml