perf: reduce MemBefore initial size
#684
Merged
+174
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
wborgeaud,
muursh and
LindaGuiga
as code owners
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
force-pushed
the
perf/reduce_mem_before
branch
from
0f08be6
to
7755d46
Compare
LindaGuiga
approved these changes
Oct 5, 2024
evm_arithmetization/src/cpu/kernel/asm/core/precompiles/bn_add.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/hash/blake2/blake2_f.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/core/jumpdest_analysis.asm
Outdated
Show resolved
Hide resolved
hratoanina
reviewed
Oct 5, 2024
hratoanina
approved these changes
Oct 10, 2024
evm_arithmetization/src/cpu/kernel/asm/core/precompiles/blake2_f.asm
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce KERNEL size to allow initial
MemBeforeto fit in2^16rows (currently padded to 2^17).Also address the TODO on
gas_hook, as we haven't had any gas discrepancies since full completion of the Ethereum test suite, and this is saving a couple hundred thousand cycles for mainnet blocks (while also reducing KERNEL code size).Most of the savings are around removing the heavy PUSHes (for large values), and reordering stack elements.
Current KERNEL code size as of 3a220c1:
eth_mainnet: 64559cdk_erigon: 63858 (though this will probably go over the limit again once plugging thesmtcode)Ran through the Ethereum test suite for consistency