perf: Improve PUSH checking in JDA #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hratoanina
requested review from
wborgeaud,
muursh,
Nashtare and
LindaGuiga
as code owners
github-actions
bot
added
the
crate: evm_arithmetization
4l0n50
reviewed
Oct 4, 2024
evm_arithmetization/src/cpu/kernel/asm/core/jumpdest_analysis.asm
Outdated
Show resolved
Hide resolved
Checked on mainnet blocks, removes ~2.3% CPU cycles |
4l0n50
approved these changes
Oct 4, 2024
Nashtare
approved these changes
Oct 4, 2024
muursh
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the current
write_table_if_jumpdestASM code with a simpler argument.Reduces the kernel code by ~350 bytes (though a bit less because of the overlap with #684) and removes ~2800 cycles for ERC721.