Work on SHA256 and set of related improvements #528
Merged
Commits on Aug 22, 2023
-
Fix dirty overload of Keccak function
The Keccak function was overloaded with a set of options to generate JSON files. This commit separates this logic into `keccak_gen`, which hopefully can also be adopted as a pattern for upcoming work on `sm/sha256` and `sm/blake`.
-
Add config files for hash function tests
This commit makes it easier to run test vectors targeting hash functions.
-
Commits on Aug 24, 2023
-
-
Eliminate KeccakState in favor of GateState
This replaces KeccakState with GateState, which we can then use for all future primitives that we implement as arithmetic gates (SHA256, BLAKE2, and others).
Commits on Aug 25, 2023
Commits on Aug 29, 2023
-
Disable non-functioning Keccak SM tests
Confirmed as not functional with @fractasy on August 29th, 2023.
Commits on Aug 31, 2023
-
Fix dirty overload of Keccak function
The Keccak function was overloaded with a set of options to generate JSON files. This commit separates this logic into `keccak_gen`, which hopefully can also be adopted as a pattern for upcoming work on `sm/sha256` and `sm/blake`.
-
Add config files for hash function tests
This commit makes it easier to run test vectors targeting hash functions.
-
-
-
Eliminate KeccakState in favor of GateState
This replaces KeccakState with GateState, which we can then use for all future primitives that we implement as arithmetic gates (SHA256, BLAKE2, and others).
-
-
Very unsure that this works correctly, need external review.
-
-
Disable non-functioning Keccak SM tests
Confirmed as not functional with @fractasy on August 29th, 2023.
-
-
-
Merge branch 'nadim-sha256' of github.com:0xPolygonHermez/zkevm-prove…
…r into nadim-sha256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.