Work on SHA256 and set of related improvements #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Keccak function was overloaded with a set of options to generate JSON files. This commit separates this logic into `keccak_gen`, which hopefully can also be adopted as a pattern for upcoming work on `sm/sha256` and `sm/blake`.
This commit makes it easier to run test vectors targeting hash functions.
This replaces KeccakState with GateState, which we can then use for all future primitives that we implement as arithmetic gates (SHA256, BLAKE2, and others).
Very unsure that this works correctly, need external review.
Confirmed as not functional with @fractasy on August 29th, 2023.
The Keccak function was overloaded with a set of options to generate JSON files. This commit separates this logic into `keccak_gen`, which hopefully can also be adopted as a pattern for upcoming work on `sm/sha256` and `sm/blake`.
This commit makes it easier to run test vectors targeting hash functions.
This replaces KeccakState with GateState, which we can then use for all future primitives that we implement as arithmetic gates (SHA256, BLAKE2, and others).
Very unsure that this works correctly, need external review.
Confirmed as not functional with @fractasy on August 29th, 2023.
…r into nadim-sha256
nadimkobeissi
changed the title
nadim-sha256 work in progress
|
OK, everyone is very busy, this commit doesn't break anything, and I have a lot of stuff I need to do still, so I'm merging this myself. Hopefully I won't get yelled at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a set of improvements related to work on implementing the SHA256 executor.
Changes made:
GateConfiginterfaceKeccakStateto the unifiedGateStateand useGateStatefor SHA256 as wellWhile this commit implements SHA256 JSON generation, it is not yet possible to finish the implementation of the SHA256 executor pending some necessary fixes to how executors are tested. Importantly, all Keccak executor tests are broken and have been broken since well before this PR, and this must be fixed before SHA256 executor tests can be standardized. All of this will be done in a separate branch, separate PR.
PR tested as well as I could given broken tests. End-to-end test passes, SHA256 gate-based implementation and Keccak gate-based implementation tests pass as well.
I'm submitting this commit now because it's getting too big, and I've already had to rebase it on
developonce.