Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single fileops use DoMultiOperation #506

Merged
merged 19 commits into from
Aug 28, 2023
Merged

single fileops use DoMultiOperation #506

merged 19 commits into from
Aug 28, 2023

Conversation

din-mukhammed
Copy link
Contributor

@din-mukhammed din-mukhammed commented Aug 11, 2023 •
edited
Loading

A brief description of the changes in this PR:

  • single file operations use DoMultiOperation

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@din-mukhammed din-mukhammed changed the title Singleops use multiops [WIP] Singleops use multiops Aug 11, 2023
@din-mukhammed din-mukhammed marked this pull request as draft August 11, 2023 17:21
@din-mukhammed din-mukhammed changed the title [WIP] Singleops use multiops single fileops use DoMultiOperation Aug 11, 2023
@din-mukhammed din-mukhammed marked this pull request as ready for review August 11, 2023 20:19
@devyetii
Copy link
Contributor

LGTM

devyetii
devyetii approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@devyetii devyetii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@din-mukhammed din-mukhammed mentioned this pull request Aug 12, 2023
Closed
This was referenced Aug 15, 2023
Merged
Merged
Merged
@din-mukhammed din-mukhammed changed the base branch from sprint-july-4 to staging August 16, 2023 19:56
@din-mukhammed din-mukhammed changed the base branch from staging to sprint-1.10 August 18, 2023 11:33
@din-mukhammed din-mukhammed changed the title single fileops use DoMultiOperation [WIP] single fileops use DoMultiOperation Aug 24, 2023
@din-mukhammed din-mukhammed changed the title [WIP] single fileops use DoMultiOperation single fileops use DoMultiOperation Aug 27, 2023
@dabasov dabasov merged commit 4e6b1dc into sprint-1.10 Aug 28, 2023
3 checks passed
@dabasov dabasov deleted the replace-with-multiops branch August 28, 2023 12:47
@din-mukhammed din-mukhammed mentioned this pull request Aug 29, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyetii devyetii devyetii approved these changes

@dabasov dabasov Awaiting requested review from dabasov

@guruhubb guruhubb Awaiting requested review from guruhubb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@din-mukhammed @devyetii @dabasov