Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forbid_rename option from denying uploads #1214

Merged
merged 12 commits into from
Aug 28, 2023

Conversation

din-mukhammed
Copy link
Contributor

@din-mukhammed din-mukhammed commented Aug 16, 2023

Fixes

  • Deleted CanRename() check when creating connection object

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #1214 (feddd6f) into sprint-1.10 (e154a63) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           sprint-1.10    #1214   +/-   ##
============================================
  Coverage        25.53%   25.54%           
============================================
  Files               83       83           
  Lines             9353     9346    -7     
============================================
- Hits              2388     2387    -1     
+ Misses            6668     6664    -4     
+ Partials           297      295    -2     
Flag Coverage Δ
Unit-Tests 25.54% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ain.net/blobbercore/handler/file_command_upload.go 40.74% <ø> (+0.37%) ⬆️
...et/blobbercore/handler/object_operation_handler.go 18.68% <0.00%> (+0.04%) ⬆️

@din-mukhammed din-mukhammed marked this pull request as ready for review August 16, 2023 19:33
@din-mukhammed din-mukhammed changed the base branch from staging to sprint-1.10 August 18, 2023 11:33
@din-mukhammed din-mukhammed changed the title Fix forbid_rename option from denying uploads [WIP] Fix forbid_rename option from denying uploads Aug 24, 2023
@din-mukhammed din-mukhammed changed the title [WIP] Fix forbid_rename option from denying uploads Fix forbid_rename option from denying uploads Aug 27, 2023
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit b7df47b into sprint-1.10 Aug 28, 2023
6 checks passed
@dabasov dabasov deleted the replace-with-multiops branch August 28, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants