Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shard size to formData #1175

Merged
merged 14 commits into from
Aug 23, 2023
Merged

Add shard size to formData #1175

merged 14 commits into from
Aug 23, 2023

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Aug 18, 2023 •
edited
Loading

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@Hitenjain14 Hitenjain14 changed the base branch from staging to sprint-1.10 August 18, 2023 17:46
@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests
gosdk feat/add-size
zboxcli
zwalletcli
0chain
blobber
authorizer
0box
0dns

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk feat/add-size
zboxcli
zwalletcli
0chain
blobber
authorizer
0box
0dns

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped false
system-tests
gosdk feat/add-size
zboxcli
zwalletcli
0chain
blobber
authorizer
0box
0dns

@Hitenjain14 Hitenjain14 marked this pull request as ready for review August 22, 2023 20:10
@Hitenjain14 Hitenjain14 mentioned this pull request Aug 22, 2023
Merged
3 tasks
@Hitenjain14 Hitenjain14 mentioned this pull request Aug 22, 2023
Merged
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk sprint-1.10
zboxcli
zwalletcli
0chain
blobber
authorizer
0box
0dns

dabasov
dabasov approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 2ba5110 into sprint-1.10 Aug 23, 2023
10 of 11 checks passed
@dabasov dabasov deleted the feat/add-size branch August 23, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hitenjain14 @service-0chain @dabasov