Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate hash on upload #1217

Merged
merged 28 commits into from
Aug 23, 2023
Merged

Calculate hash on upload #1217

merged 28 commits into from
Aug 23, 2023

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Aug 18, 2023

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Merging #1217 (cc8193e) into sprint-1.10 (0a01870) will increase coverage by 0.08%.
The diff coverage is 37.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           sprint-1.10    #1217      +/-   ##
===============================================
+ Coverage        25.45%   25.53%   +0.08%     
===============================================
  Files               83       83              
  Lines             9277     9353      +76     
===============================================
+ Hits              2361     2388      +27     
- Misses            6625     6668      +43     
- Partials           291      297       +6     
Flag Coverage Δ
Unit-Tests 25.53% <37.03%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
code/go/0chain.net/blobbercore/filestore/store.go 0.00% <ø> (ø)
...ain.net/blobbercore/handler/file_command_update.go 0.00% <0.00%> (ø)
.../go/0chain.net/blobbercore/writemarker/protocol.go 0.00% <0.00%> (ø)
...in.net/blobbercore/allocation/file_changer_base.go 45.23% <25.00%> (-2.14%) ⬇️
...ain.net/blobbercore/handler/file_command_upload.go 40.36% <36.00%> (-0.33%) ⬇️
...chain.net/blobbercore/filestore/tree_validation.go 78.57% <44.44%> (-0.74%) ⬇️
...ode/go/0chain.net/blobbercore/filestore/storage.go 39.25% <57.14%> (+0.18%) ⬆️
...go/0chain.net/blobbercore/allocation/connection.go 26.08% <66.66%> (+26.08%) ⬆️

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 090e715 into sprint-1.10 Aug 23, 2023
5 of 6 checks passed
@dabasov dabasov deleted the fix/hash-calc branch August 23, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants