Endpoint to delete documents ingested #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A file that is ingested will be transformed into several documents (that are organized into nodes). This endpoint is deleting documents (bits of a file). These bits can be retrieved thanks to the endpoint to list all the documents.
imartinez
requested changes
Nov 5, 2023
lopagela
force-pushed
the
delete-endpoint
branch
from
e29775a
to
3d88c8c
Compare
imartinez
requested changes
Nov 6, 2023
* Adapted log to log file_name instead of the data itself * Undo changes in __main__.py * Change API documentation to make it more generic
imartinez
approved these changes
Nov 6, 2023
|
While uploading a single document, I won't get only one doc_id, ingest post method would return multiple doc_id based on the document size, In this case, should we call the delete API multiple times to delete the uploaded file? |
Yes, the client can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A file that is ingested will be transformed into several documents (that are organized into nodes).
This endpoint is deleting documents (bits of a file). These bits can be retrieved thanks to the endpoint to list all the documents.
Also added logs in the scope of this PR