Server rewrite/enhancement #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frederik-uni
commented
Nov 22, 2024
frederik-uni
commented
- using fastapi and therefor supporting openapi/swagger out of the box
- keeping connections alive instead of asking again and again if its finished
- stream variant which sends progress in custom format(status[1byte], size[4 bytes], data[n bytes])
- normal api which gives the final result in the end
- allowing multiple translator instances to be used by the api.
- byte response more custom encoding[not really encoded, its more a dump in binary that can be loaded in c++,...](example how to load in c++ and rust
- remove from queue when disconnected
- allow both json requests & form requests
- server & experimental api now one server
- a little bit more infos for the json response route
- more customizable requests(pass in config instead of own format, which will keep the api up to date when the project is expanded)
# Conflicts: # manga_translator/__main__.py
# Conflicts: # manga_translator/args.py # manga_translator/manga_translator.py
json&image most likely too
# Conflicts: # manga_translator/args.py # manga_translator/manga_translator.py
json&image most likely too
|
PR #745 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.