Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak 12A0 for ClimaRad HVAC #142

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Tweak 12A0 for ClimaRad HVAC #142

wants to merge 21 commits into from

Conversation

silverailscolo
Copy link
Contributor

parser, regex, TypedDict with inherit/moved, logs

@silverailscolo silverailscolo mentioned this pull request Oct 17, 2024
Open
@silverailscolo silverailscolo changed the title Tweak 12A0 Tweak 12A0 for ClimaRad HVAC Oct 17, 2024
zxdavb
zxdavb requested changes Oct 18, 2024
View reviewed changes
src/ramses_tx/ramses.py Outdated Show resolved Hide resolved
src/ramses_tx/ramses.py Outdated Show resolved Hide resolved
src/ramses_tx/typed_dicts.py Outdated Show resolved Hide resolved
tests/tests/fingerprints/hvac/37_VMD-07RPS13.log Outdated Show resolved Hide resolved
tests/tests/parsers/code_12a0.log Outdated Show resolved Hide resolved
src/ramses_tx/typed_dicts.py Outdated Show resolved Hide resolved
src/ramses_tx/typed_dicts.py Outdated Show resolved Hide resolved
src/ramses_tx/parsers.py Outdated Show resolved Hide resolved
@silverailscolo silverailscolo requested a review from zxdavb October 18, 2024 14:39
@zxdavb
Copy link
Owner

zxdavb commented Oct 20, 2024

I have refactored the typed dicts - you'll have to rebase.

zxdavb
zxdavb requested changes Oct 20, 2024
View reviewed changes
src/ramses_tx/parsers.py Outdated Show resolved Hide resolved
src/ramses_tx/parsers.py Outdated Show resolved Hide resolved
src/ramses_tx/ramses.py Outdated Show resolved Hide resolved
src/ramses_tx/typed_dicts.py Outdated Show resolved Hide resolved
src/ramses_tx/parsers.py Outdated Show resolved Hide resolved
@silverailscolo
Copy link
Contributor Author

Convinced by your example parsing. Made the regex stricter by requiring 1 or more of these elements in the packet.
Added a humidity_element parser that can handle the name of indoor and outdoor (based on index as extracted from the packet list).
What do we need to do here - or in ramses_cc - to make sure Home Assistant understands the results and maps them to typical HRU properties?

@silverailscolo silverailscolo requested a review from zxdavb October 20, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxdavb zxdavb Awaiting requested review from zxdavb

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverailscolo @zxdavb