Support get_raw_config_parameter_value
#1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlCalzone Pls review |
AlCalzone
requested changes
Oct 17, 2024
AlCalzone
approved these changes
Oct 17, 2024
| @@ -8,6 +8,7 @@ export enum NodeCommand { | |||
| abortFirmwareUpdate = "node.abort_firmware_update", | |||
| pollValue = "node.poll_value", | |||
| setRawConfigParameterValue = "node.set_raw_config_parameter_value", | |||
| getRawConfigParameterValue = "node.get_raw_config_parameter_value", | |||
There was a problem hiding this comment.
We need to document the new command in the Readme and API schema for schema 39.
There was a problem hiding this comment.
Oh damn, should we have bumped the schema version aswell?
There was a problem hiding this comment.
It was already bumped in another PR in the release, so that's fine. We can just adjust the docs without a new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need GET/SET for certification and only set was supported in the server