Support all signatures of node.manuallyIdleNotificationValue

API_SCHEMA.md

@@ -77,3 +77,7 @@ Base schema.
 - Added controller `inclusion state changed` event
 - Added `config_manager` commands
 - Added `zniffer` commands
+
+# Schema 39
+
+- Added support for both overloads of `node.manuallyIdleNotificationValue`

README.md

@@ -865,7 +865,21 @@ interface {
 
 #### [Manually Idle Notification CC Value](https://zwave-js.github.io/node-zwave-js/#/api/node?id=manuallyidlenotificationvalue)
 
-[compatible with schema version: 28+]
+[compatible with schema version: 39+]
+
+This can be called in one of two ways:
+
+Method 1:
+
+```ts
+interface {
+ messageId: string;
+ command: "node.manually_idle_notification_value";
+ valueId: ValueID;
+}
+```
+
+Method 2:
 
 ```ts
 interface {

src/lib/const.ts

@@ -4,7 +4,7 @@ export const version = require("../../package.json").version;
 export const minSchemaVersion = 0;
 
 // maximal/current schema version the server supports
-export const maxSchemaVersion = 38;
+export const maxSchemaVersion = 39;
 
 export const applicationName = "zwave-js-server";
 export const dnssdServiceType = applicationName;

src/lib/node/incoming_message.ts

@@ -197,12 +197,20 @@ export interface IncomingCommandNodeGetValueTimestamp
  valueId: ValueID;
 }
 
-export interface IncomingCommandNodeManuallyIdleNotificationValue
+export interface IncomingCommandNodeManuallyIdleNotificationValueMethod1
  extends IncomingCommandNodeBase {
  command: NodeCommand.manuallyIdleNotificationValue;
  valueId: ValueID;
 }
 
+export interface IncomingCommandNodeManuallyIdleNotificationValueMethod2
+ extends IncomingCommandNodeBase {
+ command: NodeCommand.manuallyIdleNotificationValue;
+ notificationType: number;
+ prevValue: number;
+ endpointIndex?: number;
+}
+
 export interface IncomingCommandNodeSetDateAndTime
  extends IncomingCommandNodeBase {
  command: NodeCommand.setDateAndTime;
@@ -276,7 +284,8 @@ export type IncomingMessageNode =
  | IncomingCommandWaitForWakeup
  | IncomingCommandInterview
  | IncomingCommandNodeGetValueTimestamp
- | IncomingCommandNodeManuallyIdleNotificationValue
+ | IncomingCommandNodeManuallyIdleNotificationValueMethod1
+ | IncomingCommandNodeManuallyIdleNotificationValueMethod2
  | IncomingCommandNodeSetDateAndTime
  | IncomingCommandNodeGetDateAndTime
  | IncomingCommandNodeIsHealthCheckInProgress

src/lib/node/message_handler.ts

@@ -272,7 +272,15 @@ export class NodeMessageHandler {
  return { timestamp };
  }
  case NodeCommand.manuallyIdleNotificationValue: {
- node.manuallyIdleNotificationValue(message.valueId);
+ if ("valueId" in message) {
+ node.manuallyIdleNotificationValue(message.valueId);
+ } else {
+ node.manuallyIdleNotificationValue(
+ message.notificationType,
+ message.prevValue,
+ message.endpointIndex,
+ );
+ }
  return {};
  }
  case NodeCommand.setDateAndTime: {