-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aeotec ZW175-C EU firmware version 1.3 #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the IF statement, you may need to change this statement:
"$if": "firmwareVersion < 1.3",
"version": "1.3",
to
"$if": "firmwareVersion < 1.3.1",
"version": "1.3.1",
Most ZW175-C units are already on V1.3.0 so it may not go through, need the 3rd decimal point to get it to others. Otherwise everything else looks good.
According to the documentation, that is not necessary, patch number As for the current shipping firmware, I recently bought a large number of ZW175-C which were apparently shipped directly from Z-Wave Europe GmbH and so far all were on 1.2. |
Ah ok, that was my misunderstanding and probably quickly glanced over it. This is fine then. |
Just to clarify, the Not sure if that's what you intended with the other definitions @Aeotec-ccheng ? |
@Aeotec-ccheng Is it necessary to prevent downgrades? |
@AlCalzone ah ok that makes sense - it isn't but if it can't be helped then that's fine. @mundschenk-at it isn't necessary to prevent downgrades, but in some cases downgrade of a specific version can cause bricking in some of our devices. This particular device doesn't care so much |
@AlCalzone Should I change the PR to allow downgrades? |
IMO allowing users to downgrade where it is supported would be good. |
OK, I've removed the |
Thanks! I'll just need a final confirmation from @Aeotec-ccheng then I'll merge. |
@AlCalzone Don't see any issues, just confirming everything is good (file URL and hash) |
This adds firmware 1.3 for the EU version of the Aeotec Smart Switch 7 which was recently made available. It fixes a rather annoying bug where the change threshold settings don't do anything when the initial value is above 0 (at least for the Watts sensor, though I'm not entirely sure other sensors were not affected as well).
@Aeotec-ccheng Could you please review this PR?