-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New onboading pages #44
base: main
Are you sure you want to change the base?
Conversation
- Change the onboarding wrapper logo - Put a background image for the wrapper - Changed the positioning of the logo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have alternate pages for signup and otp?
<NumberInput | ||
hideControls | ||
classNames={{ input: classes.input }} | ||
h={45} | ||
w={50} | ||
maxLength={1} | ||
/> | ||
<NumberInput | ||
hideControls | ||
classNames={{ input: classes.input }} | ||
h={45} | ||
w={50} | ||
maxLength={1} | ||
/> | ||
<NumberInput | ||
hideControls | ||
classNames={{ input: classes.input }} | ||
h={45} | ||
w={50} | ||
maxLength={1} | ||
/> | ||
<NumberInput | ||
hideControls | ||
classNames={{ input: classes.input }} | ||
h={45} | ||
w={50} | ||
maxLength={1} | ||
/> | ||
<NumberInput | ||
hideControls | ||
classNames={{ input: classes.input }} | ||
h={45} | ||
maxLength={1} | ||
w={50} | ||
/> | ||
<NumberInput | ||
hideControls | ||
classNames={{ input: classes.input }} | ||
h={45} | ||
maxLength={1} | ||
w={50} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This number input doesn't store the value anywhere.
Also Mantine provides a pin input that you can use instead of recreating that design
<FormTitle | ||
title="Verify your email address!" | ||
subtitle="We have sent your code " | ||
boldSubtitle={"[email protected]"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this mail should not be hardcoded
bg={theme.colors.secondary[5]} | ||
className={classes.continueBtn} | ||
> | ||
Continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the API is ready so this function should be connected properly
|
||
const useStyles = createStyles(theme => ({ | ||
formHeader: { | ||
position: "fixed", | ||
left: "0", | ||
right: "0", | ||
top: "0", | ||
height: "75px", | ||
borderBottom: "1px solid #F9DBB6", | ||
// height: "75px", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code
{ | ||
path: "alternative-signup", | ||
element: <LoginWrapper />, | ||
errorElement: <ErrorPage />, | ||
children: [ | ||
{ | ||
index: true, | ||
element: <AlternativeSignup /> | ||
} | ||
] | ||
}, | ||
{ | ||
path: "alternative-signup-otp", | ||
element: <LoginWrapper />, | ||
errorElement: <ErrorPage />, | ||
children: [ | ||
{ | ||
index: true, | ||
element: <AlternativeSignupOtp /> | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have alternate pages?
size="md" | ||
autoComplete="false" | ||
classNames={{ input: classes.inputField }} | ||
{...LoginForm.getInputProps("email")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you used the wrong get input props in the functions
update this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there an alternate signup page
<Button | ||
fullWidth | ||
mt="xl" | ||
size="md" | ||
variant="outline" | ||
disabled={true} | ||
className={classes.outlineBtn} | ||
leftIcon={<IconBrandGoogle size={14} />} | ||
> | ||
Login with Google | ||
</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need the login with google button for now
Enter here | ||
</Text> | ||
<Flex gap={10} justify="space-between"> | ||
<NumberInput |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the pin input instead
<Button | ||
fullWidth | ||
mt="xl" | ||
size="md" | ||
variant="outline" | ||
disabled={true} | ||
className={classes.outlineBtn} | ||
leftIcon={<IconBrandGoogle size={14} />} | ||
> | ||
Login with Google |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove google signup
Fixes Issue/Linear Ticket
Changes proposed
Onboarding pages
Check List (Check all the applicable boxes)
🚨Please review the style guide for contributing and guidelines for contributing to this repository.
Screenshots/ Videos