Some build fixes (changed sq API, and a missing file on iOS)
#5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
reviewed
Sep 30, 2024
tools/postinstall
Outdated
Comment on lines
13
to
14
| ( cd node_modules/react-native/packages/react-native-codegen/ && \ | ||
| yarn clean && node scripts/build.js ) |
There was a problem hiding this comment.
Given the set -e, this doesn't need &&:
Suggested change
| ( cd node_modules/react-native/packages/react-native-codegen/ && \ | |
| yarn clean && node scripts/build.js ) | |
| ( | |
| cd node_modules/react-native/packages/react-native-codegen/ | |
| yarn clean | |
| node scripts/build.js | |
| ) |
(Or maybe the latter two commands can stay in && form to stick closer to the yarn build script.)
Then a comment mentioning that this is based on the package's yarn build would be helpful. Otherwise it's left a bit mysterious why we do these particular steps.
gnprice
reviewed
Sep 30, 2024
| @@ -57,8 +57,8 @@ filter_sq_stderr() { | |||
| grep -vE '^(Compressed|Encrypted) ' | |||
| } | |||
|
|
|||
| sq decrypt --recipient-key "${recipient_key}" \ | |||
| -o "${cleartext}" "${cryptotext}" \ | |||
| sq decrypt --recipient-file "${recipient_key}" \ | |||
There was a problem hiding this comment.
The Sequoia CLI's changelog doesn't seem to mention these changes:
https://gitlab.com/sequoia-pgp/sequoia-sq/-/blob/b4158f40dea64655cf7357d3c8f220e8bd1708d9/NEWS
But they're easy enough to adapt to; shrug.
Looks like this was here:
https://gitlab.com/sequoia-pgp/sequoia/-/commit/db90178d5b61e3310f979fdaefc66610adf0d33e
https://gitlab.com/sequoia-pgp/sequoia/-/issues/933
Happened a couple of years ago; guess I hadn't updated my sq install either. (But I have now, and it has the new names.)
gnprice
reviewed
Sep 30, 2024
The Sequoia CLI's changelog doesn't seem to mention these changes: https://gitlab.com/sequoia-pgp/sequoia-sq/-/blob/b4158f40dea64655cf7357d3c8f220e8bd1708d9/NEWS The `--recipient-file` rename, anyway, looks like it happened here: https://gitlab.com/sequoia-pgp/sequoia/-/commit/db90178d5b61e3310f979fdaefc66610adf0d33e https://gitlab.com/sequoia-pgp/sequoia/-/issues/933 Shrug; these changes are easy enough to adapt to. ``` $ sq version sq 0.38.0 using sequoia-openpgp 1.21.2 with cryptographic backend Nettle 3.10 (Cv448: true, OCB: true) ```
…egen We recently started building RN from Git, in 0509575. This caused an iOS build failure in the shell script '[CP-User] Generate Specs': Error: Cannot find module '/Users/chrisbobbe/dev/zulip-mobile/node_modules/react-native/packages/react-native-codegen/lib/cli/combine/combine-js-to-schema-cli.js' Note the last part: [...]/lib/cli/combine/combine-js-to-schema-cli.js' There is a [...]/src/[...] version of that file, but the /lib/ one is created by `yarn build`, and when I ran that, the app build succeeded.
chrisbobbe
force-pushed
the
pr-build-fixes
branch
from
ff37b14
to
1db6467
Compare
|
Thanks! Revision pushed. |
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the
sqchanges by installingsqon my new laptop; this was the first release build I've done on it.