deps: Upgrade react-native-simple-toast to 3.3.1, the latest #5858
+96
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this causes a peer-dependency warning: warning " > [email protected]" has incorrect peer dependency "react-native@>=0.71.0". but no issues are observed in manual testing of this library's functionality on iOS or Android. While we're at it, use TsFlower for the types. The types tell us that `Toast.show`'s duration parameter is required; so, include it, even though the implementation has logic to fall back to Toast.SHORT if the argument isn't passed. This lets us pull in the latest version of the "Toast" pod for iOS; that's version 4.1.1. That version has a "privacy manifest" -- scalessec/Toast@401141d79 scalessec/Toast@607b12954 scalessec/Toast@85b492dd8 -- which should hopefully help us with zulip#5847. Granted, the Toast pod's privacy manifest file seems pretty boring; I think it just declares that the library doesn't access any sensitive data. Still, "Toast" is explicitly included in a list published by Apple of "commonly used SDKs" that require their own privacy manifest: https://developer.apple.com/support/third-party-SDK-requirements/ (In fact, I think it's the only one of zulip-mobile's dependencies that appears in that list.) Related: zulip#5847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this causes a peer-dependency warning:
warning " > [email protected]" has incorrect peer
dependency "react-native@>=0.71.0".
but no issues are observed in manual testing of this library's functionality on iOS or Android.
While we're at it, use TsFlower for the types. The types tell us that
Toast.show's duration parameter is required; so, include it, even though the implementation uses a fallback value (Toast.SHORT) if the argument isn't passed.This lets us pull in the latest version of the "Toast" pod for iOS; that's version 4.1.1. That version has a "privacy manifest" --
scalessec/Toast@401141d79
scalessec/Toast@607b12954
scalessec/Toast@85b492dd8
-- which should hopefully help us with #5847. Granted, the Toast pod's privacy manifest file seems pretty boring; I think it just declares that the library doesn't access any sensitive data. Still, "Toast" is explicitly included in a list published by Apple of "commonly used SDKs" that require their own privacy manifest:
https://developer.apple.com/support/third-party-SDK-requirements/
(In fact, I think it's the only one of zulip-mobile's dependencies that appears in that list.)
Related: #5847