Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle @topic mentions #5779

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Handle @topic mentions #5779

merged 3 commits into from
Oct 20, 2023

Commits on Oct 20, 2023

  1. WildcardMentionItem [nfc]: Refactor to prepare for adding "topic" men… 

    …tion

As Greg suggests:
  zulip#5779 (comment)

> The main thing to do in the code is that in retrospect the
> existing version probably stretches too hard to make it
> table-driven, with those constants `kOrderedTypes…`, rather than
> writing out logic in code in the function. If we do the latter, it
> becomes pretty straightforward to add `@topic` without losing dupe
> suppression on the others.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    0034e2f View commit details
    Browse the repository at this point in the history

  2. autocomplete: Add @topic to @-mention autocomplete 

    Fixes: zulip#5772
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    05b7332 View commit details
    Browse the repository at this point in the history

  3. content: Render @topic mentions correctly 

    Fixes: zulip#5746
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    0f3cbae View commit details
    Browse the repository at this point in the history