Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Stop assuming fetched messages' reactions have deprecated user field #5773

Merged
merged 1 commit into from
Oct 3, 2023

Commits on Oct 3, 2023

  1. api: Stop assuming fetched messages' reactions have deprecated user

    … field
    
    Our code at the edge for transforming the old format of reactions,
    with `user`, into the new format, with `user_id`, was depending on
    `user` always being present.
    
    Since `user_id` is documented as being added in Zulip 3.0:
      https://zulip.com/api/get-messages#response
    , and since zulip#5747 we've been refusing to connect to servers pre-3.0,
    we can assume `user_id` is always present and stop reading `user`.
    
    Fixes: zulip#4072
    chrisbobbe authored and gnprice committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    df1dd79 View commit details
    Browse the repository at this point in the history