Disable Sentry for now on Android (cherry-pick from v27.213) #5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for zulip#5757, the crashes we've started to regularly see as many users' devices have started taking the Google Play system update dated 2023-08. See the (long) chat thread here: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.20crashes/near/1640893 and issue threads reported in Android's and Sentry's trackers: https://issuetracker.google.com/issues/300840851 https://github.com/getsentry/sentry-unity/issues/1444 Our issue for re-enabling Sentry on Android is zulip#5766. This commit was cherry-picked from 29cea89, part of v27.213, with tweaks to mention zulip#5766.
|
Thanks, LGTM! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the rush to get v27.213 out the door as a fix for #5757 — and partly because I was hopeful that the Sentry folks would be finding a fix soon — I made these changes directly on a release branch, rather than on main first and cherry-picking to a release branch.
Here they are for
main, along with the changelog entry for v27.213.