Upgrade Flutter and all packages to latest

[chrisbobbe]

Done because it's the first step in our plan for #612, the "Missing API declaration" warning from Apple.

Changelogs for deps that are major-version upgraded:
https://pub.dev/packages/device_info_plus/changelog
https://pub.dev/packages/file_picker/changelog
https://pub.dev/packages/flutter_local_notifications/changelog
https://pub.dev/packages/package_info_plus/changelog
https://pub.dev/packages/share_plus/changelog
https://pub.dev/packages/pigeon/changelog

Manual tests done:

• My iPhone 13 Pro running iOS 17.3.1:
  • App starts up; pages load (including Inbox and message list)
• Office Android device (Samsung Galaxy S9 running Android 9):
  • App starts up; pages load (including Inbox and message list)
  • DM notification received; navigates to conversation when tapped
  • device_info_plus exercised and seems to work correctly (discussion)

Related: #612

[gnprice]

Thanks!

All these changes look good. I won't have time to read those changelogs before heading out on vacation; but if you've read them and nothing jumps out at you, and given that it passes your manual testing, please go ahead and merge. I looked through all these changes other than reading the changelogs.

All of these changelogs except `pigeon` mention adding "privacy
info" or "privacy manifest" in the version we're taking here --
exactly the kind of thing we want to see, with #612 in mind.

Great!

I would
guess that `pigeon` doesn't need one, as it's mainly just a code
generator tool.

Yeah. And more concretely: it's a dev dependency only, so it's not part of the actual app build.

[chrisbobbe]

Hmm, a CI failure:

Error: there were changes to pigeons:
 M android/app/src/main/kotlin/com/zulip/flutter/Notifications.g.kt
 M lib/host/android_notifications.g.dart

But when I run tools/check pigeon or tools/check pigeon --all-files locally, at the tip of this PR branch, it succeeds without error.

[gnprice]

Ah, and CI is failing — looks like you just need to update the Pigeon-generated output.

(And then I guess rerun the manual testing, unless the changes are trivial.)

[gnprice]

Huh odd.

I guess one thing you can do to debug is to edit tools/check to print the full diff in that case, rather than the status.

[gnprice]

Alternatively, try making a meaningless edit to the Pigeon input file and rerunning Pigeon — wonder if this is a caching issue, like the one we've seen with other code generators (using build_runner).

[chrisbobbe]

I guess one thing you can do to debug is to edit tools/check to print the full diff in that case, rather than the status.

Aha, this seems like a useful clue from that output:

-// Autogenerated from Pigeon (v17.2.0), do not edit directly.
+// Autogenerated from Pigeon (v18.0.0), do not edit directly.

[chrisbobbe]

The issue seems to be that the old Pigeon 17 is running locally despite the upgrade in the headline commit taking it to Pigeon 18. The command tools/check pigeon --all-files kept succeeding.

Then I did something different:

$ dart run pigeon
Resolving dependencies in `/Users/chrisbobbe/dev/zulip-flutter`... 
Downloading packages... 
Got dependencies in `/Users/chrisbobbe/dev/zulip-flutter`.
Building package executable... (5.2s)
Built pigeon:pigeon.
Pigeon is a tool for generating type-safe communication code between Flutter
and the host platform.

usage: pigeon --input <pigeon path> --dart_out <dart path> [option]*
[…]

and thereafter, tools/check pigeon --all-files is failing, which is the expected behavior from Pigeon 18. I think the Building package executable... step is what got it working. Is there a nice way to make sure that step gets run automatically whenever our Pigeon version changes?

[chrisbobbe]

Anyway, revision pushed; tools/check pigeon should be happy now.

[chrisbobbe]

And I've just redone manual tests for Android notifications. (The code did look NFC to me, but just for good measure.)

All these changes look good. I won't have time to read those changelogs before heading out on vacation; but if you've read them and nothing jumps out at you, and given that it passes your manual testing, please go ahead and merge.

Cool; yep. Merging.

[chrisbobbe]

Filed #622 for the Pigeon version issue.