modify template to proper toml format #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinxCappa
force-pushed
the
toml
branch
2 times, most recently
from
1586e95
to
67d6dda
Compare
yejiayu
suggested changes
Jun 28, 2024
Existing config that is generated is not processed correctly with latest version of frp (v0.58.1) due to formatting. Signed-off-by: Eddie Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing config that is generated is not processed correctly with latest version of frp (v0.58.1) due to formatting.
IMPORTANT: Please do not create a Pull Request without creating an issue first!
(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).
Summary
This PR fixes the toml configuration generated in the configmap by the operator
Type of Change
This PR fixes/implements the following bugs/features:
How has this been tested?
Proof: Can be provided if necessary
Checklist: