Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor unnecessary else / elif when if block has a return statement #3

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

deepsource-autofix[bot]
Copy link

The use of else or elif becomes redundant and can be dropped if the last statement under the leading if / elif block is a return statement.
In the case of an elif after return, it can be written as a separate if block.
For else blocks after return, the statements can be shifted out of else. Please refer to the examples below for reference.

Refactoring the code this way can improve code-readability and make it easier to maintain.

…`return` statement

The use of `else` or `elif` becomes redundant and can be dropped if the last statement under the leading `if` / `elif` block is a `return` statement.
In the case of an `elif` after `return`, it can be written as a separate `if` block.
For `else` blocks after `return`, the statements can be shifted out of `else`. Please refer to the examples below for reference.

Refactoring the code this way can improve code-readability and make it easier to maintain.
@Ro0t-set Ro0t-set merged commit 399f9a0 into main Jan 26, 2024
3 checks passed
@Ro0t-set Ro0t-set deleted the deepsource-autofix-b02540fb branch January 26, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant