Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature build position checks #44

Merged
merged 10 commits into from
Oct 11, 2023
Merged

Conversation

manuandru
Copy link
Contributor

A player can build a road only if:

  • it will be build near another road of the same player
  • it will be build near a settlement of the player

A player can build a settlement only if:

  • the settlement does not have other settlement in the neighbour spot

In order to achieve this result, I've modified some previous tests that do not care about these rules.

@manuandru manuandru requested review from luigi-borriello00 and alemazzo and removed request for luigi-borriello00 October 10, 2023 18:24
Copy link
Member

@alemazzo alemazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, we really needed this feature! Our players will sure enjoy this rules 🔥

Copy link
Collaborator

@luigi-borriello00 luigi-borriello00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, very useful for the Game!

@manuandru manuandru merged commit 6aafda9 into develop Oct 11, 2023
9 checks passed
@manuandru manuandru deleted the feature-build-position-checks branch October 11, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants