Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature new dsl #39

Merged
merged 12 commits into from
Oct 11, 2023
Merged

Feature new dsl #39

merged 12 commits into from
Oct 11, 2023

Conversation

alemazzo
Copy link
Member

@alemazzo alemazzo commented Oct 10, 2023 •
edited
Loading

  • Removed the old DSL
  • Introduced the new DSL to create game rules
  • Cleanup code & Imports

luigi-borriello00
luigi-borriello00 reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@luigi-borriello00 luigi-borriello00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some docs to this magic code :)

manuandru
manuandru approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@manuandru manuandru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next project, we will write a framework for pure functional programming 👽

luigi-borriello00
luigi-borriello00 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@luigi-borriello00 luigi-borriello00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many times do you want to change the DSL? YES :)
Btw, great Job!

@luigi-borriello00 luigi-borriello00 merged commit 311033d into develop Oct 11, 2023
9 checks passed
@alemazzo alemazzo deleted the feature-new-dsl branch October 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigi-borriello00 luigi-borriello00 luigi-borriello00 approved these changes

@manuandru manuandru manuandru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alemazzo @manuandru @luigi-borriello00