chore: cleanup test code

zucchero-sintattico · Sep 19, 2023 · 963a426 · 963a426
1 parent 4fa79ee
commit 963a426
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 22 deletions.
diff --git a/src/test/scala/scatan/model/building/BuildingTest.scala b/src/test/scala/scatan/model/building/BuildingTest.scala
@@ -9,7 +9,6 @@ class BuildingTest extends BaseTest:
 
   "A Building" should "exists" in {
     val building: Building = Building(BuildingType.Settlement)
-    building should not be null
   }
 
   it should "have a building type" in {

diff --git a/src/test/scala/scatan/model/building/BuildingTypeTest.scala b/src/test/scala/scatan/model/building/BuildingTypeTest.scala
@@ -12,22 +12,18 @@ class BuildingTypeTest extends BaseTest:
 
   "A BuildingType" should "exists" in {
     val buildingType: BuildingType = BuildingType.Settlement
-    buildingType should not be null
   }
 
   it should "be able to be a settlement" in {
     val buildingType: BuildingType = BuildingType.Settlement
-    buildingType should be(BuildingType.Settlement)
   }
 
   it should "be able to be a city" in {
     val buildingType: BuildingType = BuildingType.City
-    buildingType should be(BuildingType.City)
   }
 
   it should "be able to be a road" in {
     val buildingType: BuildingType = BuildingType.Road
-    buildingType should be(BuildingType.Road)
   }
 
 class BuildingTypeCostTest extends BaseTest:
@@ -49,7 +45,6 @@ class BuildingTypeCostTest extends BaseTest:
         Rock * 3
       )
     )
-
   }
 
   "A Road" should "cost 1 wood, 1 brick" in {

diff --git a/...odel/development/DevelpmentCardTest.scala → ...del/development/DevelopmentCardTest.scala b/...odel/development/DevelpmentCardTest.scala → ...del/development/DevelopmentCardTest.scala
@@ -5,11 +5,10 @@ import org.scalatest.matchers.should
 import scatan.model.{DevelopmentCard, DevelopmentType}
 import scatan.BaseTest
 
-class DevelpmentCardTest extends BaseTest:
+class DevelopmentCardTest extends BaseTest:
 
   "A DevelopmentCard" should "exists" in {
     val developmentCard: DevelopmentCard = DevelopmentCard(DevelopmentType.Knight)
-    developmentCard should not be null
   }
 
   it should "have a development type" in {

diff --git a/src/test/scala/scatan/model/development/DevelopmentTypeTest.scala b/src/test/scala/scatan/model/development/DevelopmentTypeTest.scala
@@ -9,30 +9,24 @@ class DevelopmentTypeTest extends BaseTest:
 
   "A DevelopmentType" should "exists" in {
     val developmentType: DevelopmentType = DevelopmentType.Knight
-    developmentType should not be null
   }
 
   it should "be able to be a knight" in {
     val developmentType: DevelopmentType = DevelopmentType.Knight
-    developmentType should be(DevelopmentType.Knight)
   }
 
   it should "be able to be a victory point" in {
     val developmentType: DevelopmentType = DevelopmentType.VictoryPoint
-    developmentType should be(DevelopmentType.VictoryPoint)
   }
 
   it should "be able to be a road building" in {
     val developmentType: DevelopmentType = DevelopmentType.RoadBuilding
-    developmentType should be(DevelopmentType.RoadBuilding)
   }
 
   it should "be able to be a monopoly" in {
     val developmentType: DevelopmentType = DevelopmentType.Monopoly
-    developmentType should be(DevelopmentType.Monopoly)
   }
 
   it should "be able to be a year of plenty" in {
     val developmentType: DevelopmentType = DevelopmentType.YearOfPlenty
-    developmentType should be(DevelopmentType.YearOfPlenty)
   }
diff --git a/src/test/scala/scatan/model/resource/ResourceCardTest.scala b/src/test/scala/scatan/model/resource/ResourceCardTest.scala
@@ -9,7 +9,6 @@ class ResourceCardTest extends BaseTest:
 
   "A ResourceCard" should "exists" in {
     val resourceCard: ResourceCard = ResourceCard(ResourceType.Brick)
-    resourceCard should not be null
   }
 
   it should "have a resource type" in {

diff --git a/src/test/scala/scatan/model/resource/ResourceTypeTest.scala b/src/test/scala/scatan/model/resource/ResourceTypeTest.scala
@@ -8,31 +8,25 @@ import scatan.BaseTest
 class ResourceTypeTest extends BaseTest:
 
   "A ResourceType" should "exists" in {
-    val resourceType: ResourceType = ResourceType.Brick
-    resourceType should not be null
+    val resourceType: ResourceType = ResourceType.Wood
   }
 
   it should "be able to be a wood" in {
     val resourceType: ResourceType = ResourceType.Wood
-    resourceType should be(ResourceType.Wood)
   }
 
   it should "be able to be a brick" in {
     val resourceType: ResourceType = ResourceType.Brick
-    resourceType should be(ResourceType.Brick)
   }
 
   it should "be able to be a sheep" in {
     val resourceType: ResourceType = ResourceType.Sheep
-    resourceType should be(ResourceType.Sheep)
   }
 
   it should "be able to be a wheat" in {
     val resourceType: ResourceType = ResourceType.Wheat
-    resourceType should be(ResourceType.Wheat)
   }
 
   it should "be able to be a rock" in {
     val resourceType: ResourceType = ResourceType.Rock
-    resourceType should be(ResourceType.Rock)
   }