Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spent time - Spent time should be counted by the spent_at column, not by created_at #63

Open
danielciobanica opened this issue Aug 28, 2020 · 11 comments

Comments

@danielciobanica
Copy link

danielciobanica commented Aug 28, 2020

We can add time spent on gitlab Today(2020-08-28), for last week (e.g. /spend 4h 2020-08-20).

Reports will count the hours by the created_at date which is Today (2020-08-28)

I think we should change this because the and also update the filter to search for spent_at time.

@mnvx
Copy link
Contributor

mnvx commented Aug 28, 2020

@danielciobanica Thanks for involve, please read similar issue #36

@danielciobanica
Copy link
Author

ok, i guess we can close this issue. Btw, i thought it's an open source repository. Is there any chance to push my code?

@mnvx
Copy link
Contributor

mnvx commented Aug 28, 2020

You are may fork of the project and create pull request

@danielciobanica
Copy link
Author

ok, i'll do that

@KeldNielsen86
Copy link

I am following this, as I have same feature request :).. thank you -> still using "created_at" time and not "spend_at" time

@danielciobanica
Copy link
Author

danielciobanica commented Nov 28, 2022

https://github.com/danielciobanica/gitpab

@KeldNielsen86 - You can clone the project from here. I forked it and pushed my changes to use the spend_at time

@KeldNielsen86
Copy link

KeldNielsen86 commented Nov 29, 2022

https://github.com/danielciobanica/gitpab

@KeldNielsen86 - You can clone the project from here. I forked it and pushed my changes to use the spend_at time

Hi @danielciobanica

thank you,
what else is the difference between your projects?. (I prefer just to update this project) as i had many problems installing this project on my server.)

isen 't it possible to help @mnvx in order to change this in this project? :)

thank you

regards
Keld Nielsen

@danielciobanica
Copy link
Author

@KeldNielsen86 - nothing else is different.

I created a pull-request in the past but it wasn't approved. You can read why here:

#64

@mnvx calculates employees salaries based on the time spent and he wants to make sure employee can't add time spent in the past

@KeldNielsen86
Copy link

Ahh. I see. it makes sense. (good point). If my developers register time which in the previous payment period, they will lose those hours. ( else I like the idea that they are able to register hours spend for instance yesterday, in case they forgot.

thank you for the answer

@danielciobanica
Copy link
Author

Yes, it depends on what are you using this time report for. But everybody may forget at some point to register the time spent, so that's why i needed the report based on spent_at instead of created_at

@KeldNielsen86
Copy link

KeldNielsen86 commented Dec 20, 2022

@danielciobanica Hi again, now i finally got time to "upgrade" my time registration and I did download your latest fixes, however the

/spend 30m <date in the past> command stil show me "created at" date in my gitpab. do i need to do anything else than

  • git pull
  • npm run prod
  • npm install

regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants