-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass different parameters to mktemp on OSX #4
base: master
Are you sure you want to change the base?
Conversation
Fixes #3 |
Any updates on getting this merged, @ztombol? |
@@ -99,7 +99,13 @@ temp_make() { | |||
template+='-XXXXXXXXXX' | |||
|
|||
local path | |||
path="$(mktemp --directory --tmpdir="$BATS_TMPDIR" -- "$template" 2>&1)" | |||
|
|||
if [ "$(uname -s)" == "Darwin" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't you want to detect which mktemp rather than the OS?
if mktemp --version >/dev/null 2>&1 ; then
echo Using GNU mktemp
else
echo Using BSD mktemp
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to add my remote and implement that change, I currently don't have bats
set up on my machine, and given that this PR is been ignored for about 3 months now, I don't think it's worth the effort to try to improve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified this works as expected on my mac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given mac doesn't work at all, could we land this rather than bike shed it?
@mlopes since it seems this repo is not longer maintained, I started my own fork and working on some changes there: https://github.com/peshay/bats-file/tree/patch-1 |
No description provided.