add support for WITH_CLEANUP_START
,WITH_CLEANUP_FINISH
#460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WITH_CLEANUP_START
is likeWITH_CLEANUP
.WITH_CLEANUP_FINISH
we can ignore.The tests results in fail because of a try except else inside a with statement, but anyway as you can see this error exists in 3.4 also (before
WITH_CLEANUP_START
), so it doesn't related to the handle of the with statement, only the try-except-else.I also checked and source of:
results in:
so we need to fix this anyways :) .