-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZE Webview Localization #3162
base: main
Are you sure you want to change the base?
ZE Webview Localization #3162
Conversation
Signed-off-by: likhithanimma1 <[email protected]>
📅 Suggested merge-by date: 10/20/2024 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3162 +/- ##
==========================================
+ Coverage 92.97% 93.02% +0.04%
==========================================
Files 113 113
Lines 11661 11700 +39
Branches 2576 2521 -55
==========================================
+ Hits 10842 10884 +42
+ Misses 817 814 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Quality Gate passedIssues Measures |
Signed-off-by: likhithanimma1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for localizing webview 🙏
LGTM! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking real good @likhithanimma1 thanks for working on this. I have a question, do we want the page text at the bottom of the job table webview and No items selected
to be localized as well?
I also notice that the Edit History doesn't show anything even though I have save search filters and others items that should show in the list, will double check to see if separate issue or just with this PR.
Update: this is not an issue with marketplace or with main branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment for requested changes, thanks
Proposed changes
Solves #2983
Localization of Webviews
Release Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments