Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZE Webview Localization #3162

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

ZE Webview Localization #3162

wants to merge 12 commits into from

Conversation

likhithanimma1
Copy link
Contributor

@likhithanimma1 likhithanimma1 commented Sep 30, 2024

Proposed changes

Solves #2983
Localization of Webviews

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: likhithanimma1 <[email protected]>
Copy link

github-actions bot commented Sep 30, 2024

📅 Suggested merge-by date: 10/20/2024

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.02%. Comparing base (67b0471) to head (9448f1c).

Files with missing lines Patch % Lines
...es/zowe-explorer/src/zosconsole/ZosConsolePanel.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3162      +/-   ##
==========================================
+ Coverage   92.97%   93.02%   +0.04%     
==========================================
  Files         113      113              
  Lines       11661    11700      +39     
  Branches     2576     2521      -55     
==========================================
+ Hits        10842    10884      +42     
+ Misses        817      814       -3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: likhithanimma1 <[email protected]>
@t1m0thyj t1m0thyj added this to the v3.1.0 milestone Oct 2, 2024
@t1m0thyj t1m0thyj linked an issue Oct 2, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Oct 7, 2024

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for localizing webview 🙏
LGTM! 😋

@JillieBeanSim JillieBeanSim modified the milestones: v3.1.0, v3.0.1 Oct 8, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking real good @likhithanimma1 thanks for working on this. I have a question, do we want the page text at the bottom of the job table webview and No items selected to be localized as well?
Screenshot 2024-10-08 at 1 49 34 PM

I also notice that the Edit History doesn't show anything even though I have save search filters and others items that should show in the list, will double check to see if separate issue or just with this PR.
Screenshot 2024-10-08 at 1 43 50 PM

Update: this is not an issue with marketplace or with main branch
Screenshot 2024-10-08 at 2 00 51 PM

@JillieBeanSim JillieBeanSim self-requested a review October 8, 2024 18:06
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment for requested changes, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

Localize strings in webviews
4 participants