Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Log out from API ML" missing from Manage Profile menu #2668

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

t1m0thyj
Copy link
Member

Proposed changes

Fixes #2633. The patch was made in Imperative, so the only changes in this PR are to update the Zowe CLI package and fix unit tests that broke locally after updating to Node 20.

Release Notes

Milestone: 2.14.0

Changelog: N/A since this bug fix is already listed in the changelog

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Jan 17, 2024
@t1m0thyj t1m0thyj added this to the v2.14.0 milestone Jan 17, 2024
JillieBeanSim
JillieBeanSim previously approved these changes Jan 17, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @t1m0thyj for the quick fix

zFernand0
zFernand0 previously approved these changes Jan 17, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@t1m0thyj t1m0thyj dismissed stale reviews from zFernand0 and JillieBeanSim via 90fcacd January 17, 2024 18:11
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d870b3b) 93.30% compared to head (90fcacd) 93.22%.

Files Patch % Lines
packages/zowe-explorer/src/Profiles.ts 66.66% 2 Missing ⚠️
...kages/zowe-explorer/src/utils/ProfileManagement.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
- Coverage   93.30%   93.22%   -0.08%     
==========================================
  Files         102      102              
  Lines       10546    10546              
  Branches     2278     2278              
==========================================
- Hits         9840     9832       -8     
- Misses        705      713       +8     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing the possible scenario of tokenType being undefined.
And sorry for giving you a hard time about negating an optional-chaining operator. (offline)

LGTM! 😋

@zFernand0 zFernand0 merged commit f61766e into main Jan 17, 2024
34 of 36 checks passed
@zFernand0 zFernand0 deleted the fix/apiml-dts-profiles-coexist branch January 17, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log out from API ML is not available anymore with Manage Profile menu
5 participants