Effective libopus support #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't really comment on the content of this PR, but I wanted to say that this is an excellent example of a first contribution! Keep it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to how bitrates and file formats are handled in the program to allow for an appropriate bitrate in the Opus codec, 192K is equal to MP3 320K so loads of space savings. An Opus file is about half the size of the default OGG.
It struck me after digging through the code for a bit that chances are it is in fact using the libopus codec, however with how bitrates are handled it's encoded at 320K. As I previously mentioned, 320K can be reduced to 192K with Opus without noticeable quality degradation. This bitrate reduction resolves into a final file size reduction of almost 50%.
I also included an extra printout just to inform the user as to the codec being used, it would've saved me some time when making this PR so I take that as meaning it's a useful feature to have.
Regarding the changes to
zotify/utils.py, I'm not 100% sure if that's necessary but for the sake of one line...Fixes Issue: #113
This is my first time contributing to a project, so forgive me if I've missed important details. I'm happy to have my first contribute to a tool I use!